feat:[CI-15236]: Added IMAGE_TAR_PATH as output variable for the plugin. #132
+307
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anshika2203
changed the title
Ompragash
previously requested changes
Nov 21, 2024
There was a problem hiding this comment.
add a validation check to ensure the directory for plugin_tar_path exists before use by making use of filepath.Dir, you can add this in if p.Build.TarPath != ""
also add some ut's to cover the same functionality for edge scenarios like in case of privileged and non-privileged k8s scenarios
abhay084
approved these changes
Nov 26, 2024
Ompragash
reviewed
Nov 27, 2024
Ompragash
previously requested changes
Nov 27, 2024
There was a problem hiding this comment.
CI jobs are failing with the below error though it succeeds in local - remove the use /root dir in the tests, and may be rely on DRONE_WORKSPACE as it's common for both Drone and Harness or better use os.MkdirTemp
go: downloading golang.org/x/text v0.3.7
Warning: tar_path is empty
--- FAIL: TestTarPathValidation (0.00s)
--- FAIL: TestTarPathValidation/invalid_path_no_permissions (0.00s)
kaniko_test.go:239: Expected empty tar path, got non-empty string
FAIL
FAIL github.com/drone/drone-kaniko 0.006s
ok github.com/drone/drone-kaniko/cmd/kaniko-acr 0.005s
ok github.com/drone/drone-kaniko/cmd/kaniko-docker 0.004s
? github.com/drone/drone-kaniko/cmd/kaniko-gar [no test files]
ok github.com/drone/drone-kaniko/cmd/kaniko-ecr 0.011s
? github.com/drone/drone-kaniko/cmd/kaniko-gcr [no test files]
ok github.com/drone/drone-kaniko/pkg/artifact 0.002s
ok github.com/drone/drone-kaniko/pkg/docker 0.004s
--- FAIL: TestWritePluginOutputFile (0.01s)
--- FAIL: TestWritePluginOutputFile/invalid_output_path (0.00s)
output_test.go:87: Expected error, got none
FAIL
FAIL github.com/drone/drone-kaniko/pkg/output 0.011s
Ompragash
reviewed
Nov 28, 2024
removed as getTarPath is only called when tarPath isn't empty
Ompragash
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMAGE_TAR_PATH is now accessible via a output variable and can also be used in STO steps as expression -
<+steps.STEP_ID.output.outputVariables.IMAGE_TAR_PATH>